chore(deps): bump the gradle-minor-and-patch group across 1 directory with 3 updates - #57
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
… with 3 updates Bumps the gradle-minor-and-patch group with 3 updates in the / directory: [com.google.code.gson:gson](https://github.com/google/gson), [com.google.guava:guava](https://github.com/google/guava) and [org.bouncycastle:bcprov-jdk18on](https://github.com/bcgit/bc-java). Updates `com.google.code.gson:gson` from 2.8.9 to 2.14.0 - [Release notes](https://github.com/google/gson/releases) - [Changelog](https://github.com/google/gson/blob/main/CHANGELOG.md) - [Commits](google/gson@gson-parent-2.8.9...gson-parent-2.14.0) Updates `com.google.guava:guava` from 33.6.0-android to 33.7.1-android - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) Updates `org.bouncycastle:bcprov-jdk18on` from 1.84 to 1.85.2 - [Changelog](https://github.com/bcgit/bc-java/blob/main/docs/releasenotes.html) - [Commits](https://github.com/bcgit/bc-java/commits) --- updated-dependencies: - dependency-name: com.google.code.gson:gson dependency-version: 2.14.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gradle-minor-and-patch - dependency-name: com.google.guava:guava dependency-version: 33.7.1-android dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gradle-minor-and-patch - dependency-name: org.bouncycastle:bcprov-jdk18on dependency-version: 1.85.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gradle-minor-and-patch ... Signed-off-by: dependabot[bot] <support@github.com>
77d7fd8 to
ccad880
Compare
There was a problem hiding this comment.
Review: Dependabot group bump (gson / guava / bcprov)
Thanks Dependabot. Unfortunately this can't be merged as-is: CI is failing on every JDK in the matrix.
Blocking issue — CI is red on all JDKs
The ci matrix jobs for JDK 8, 11, 16, 17, and 21 all fail at the ./gradlew clean test --info step (each job ends with Process completed with exit code 1). This is a regression introduced by this PR:
master(latest merge commit) is green on all five JDKs.- The previous Dependabot PRs (#42, #44, #48) were green on all five JDKs.
- The only delta here is the three dependency bumps (+2 transitive:
error_prone_annotations2.47.0→2.50.0 andjspecify1.0.0→1.0.1).
Because the failure is identical across every JDK, it's almost certainly a deterministic compile/test failure caused by one of the version bumps rather than flakiness or a JDK-version incompatibility.
Note: I wasn't able to open the detailed test report from the sandbox (the
failed_unit_testsartifact and raw job logs redirect to blob storage that is outside the network allowlist), so I can't name the exact failing test. Please open the failing run's logs /failed_unit_testsartifact to confirm which test broke.
Most likely cause (ranked)
- gson 2.8.9 → 2.14.0 (highest risk). This skips a lot of minor releases with behavioral changes: the new
StrictnessAPI and stricter number/JSON parsing (2.11), a duplicate-key handling change in 2.14 ({"foo": null, "foo": ...}is now rejected), removal ofSerializablefrom the internalTypeimpls, and newjava.timeadapters. This SDK also (a) leans on gson's lenient coercion of quoted numbers into numeric fields (TokenResult.expiryislongparsed from"1234567890";CardData.cvvisintparsed from"123") and (b) references the internal classcom.google.gson.internal.LinkedTreeMapdirectly inWhenPerformingHttpRequestTests. Internal-package usage is fragile across gson upgrades. - bcprov-jdk18on 1.84 → 1.85.2 (crypto).
EncryptionServiceuses the deprecated low-level primitivesnew GCMBlockCipher(new AESEngine())andnew SHA256Digest(). A behavioral change here would surface in the E2E encrypt/decrypt round-trips. - guava 33.6.0-android → 33.7.1-android (low risk). 33.7.1 specifically fixes the multi-release-manifest regression that 33.7.0 shipped, so this one is probably fine.
Additional: Socket license-policy alert
Socket raised a High severity license policy violation for org.bouncycastle:bcprov-jdk18on@1.85.2 (Bouncy Castle Licence not permitted by the org's policy). Even once CI is green this will need triage (a waiver via @SocketSecurity ignore ... / dashboard, or a policy update).
Suggested next steps
- Inspect the failing job's
failed_unit_testsartifact / logs to pin down the exact failing test(s). - Consider splitting the gson upgrade into its own PR so the group bump doesn't obscure which dependency broke the build.
- Run
./gradlew clean testlocally against each bump individually to isolate the culprit. - If the break is the internal
LinkedTreeMapusage in tests, migrate that test to a public type (e.g.java.util.Map).
| implementation 'com.google.code.gson:gson:2.8.9' | ||
| implementation 'com.google.guava:guava:33.6.0-android' | ||
| implementation group: 'org.bouncycastle', name: 'bcprov-jdk18on', version: '1.84' | ||
| implementation 'com.google.code.gson:gson:2.14.0' |
There was a problem hiding this comment.
Highest-risk change in this PR. Jumping gson 2.8.9 → 2.14.0 crosses several minor releases with behavioral changes (new Strictness/stricter number parsing since 2.11, the 2.14 duplicate-key handling change, removal of Serializable from internal Type impls, new java.time adapters). This SDK relies on lenient quoted-number coercion (e.g. TokenResult.expiry:long from "1234567890", CardData.cvv:int from "123") and on the internal com.google.gson.internal.LinkedTreeMap in WhenPerformingHttpRequestTests. Please confirm the failing test(s) here — and consider isolating the gson bump in its own PR.
| implementation group: 'org.bouncycastle', name: 'bcprov-jdk18on', version: '1.84' | ||
| implementation 'com.google.code.gson:gson:2.14.0' | ||
| implementation 'com.google.guava:guava:33.7.1-android' | ||
| implementation group: 'org.bouncycastle', name: 'bcprov-jdk18on', version: '1.85.2' |
There was a problem hiding this comment.
bcprov-jdk18on 1.84 → 1.85.2 is a crypto bump; EncryptionService uses the deprecated new GCMBlockCipher(new AESEngine()) / new SHA256Digest() primitives, so any behavior change would hit the E2E encrypt/decrypt tests. Separately, Socket flagged a High severity license-policy violation for bcprov-jdk18on@1.85.2 (Bouncy Castle Licence not allowed by org policy) that will need triage/waiver.
Bumps the gradle-minor-and-patch group with 3 updates in the / directory: com.google.code.gson:gson, com.google.guava:guava and org.bouncycastle:bcprov-jdk18on.
Updates
com.google.code.gson:gsonfrom 2.8.9 to 2.14.0Release notes
Sourced from com.google.code.gson:gson's releases.
... (truncated)
Changelog
Sourced from com.google.code.gson:gson's changelog.
... (truncated)
Commits
3ff35d6[maven-release-plugin] prepare release gson-parent-2.14.0a3024fdBump the maven group with 13 updates (#3002)5689ffeBump the github-actions group across 1 directory with 3 updates (#3018)48db33cAddLegacyProtoTypeAdapterFactory. (#3014)53d703eUpdate outdated comment regarding serializable types (#3012)0189b72RemoveSerializablefrom internalTypeimplementation classes. (#3011)f4d371dFix duplicate key detection when first value is null (#3006)27d9ba1Fix typo in README (JPMS dependencies section) (#3005)1fa9b7aValidate that strings being parsed as integers consist of ASCII characters (#...b7d5954Add iterator fail-fast tests for LinkedTreeMap.clear() (#2992)Updates
com.google.guava:guavafrom 33.6.0-android to 33.7.1-androidRelease notes
Sourced from com.google.guava:guava's releases.
... (truncated)
Commits
Updates
org.bouncycastle:bcprov-jdk18onfrom 1.84 to 1.85.2Changelog
Sourced from org.bouncycastle:bcprov-jdk18on's changelog.
... (truncated)
Commits